test(mcp): pin the stdio tool-count invariant at 70 after two mirrors landed by lourincedaging0-commits · Pull Request #6926 · JSONbored/loopover

lourincedaging0-commits · 2026-07-17T13:46:21Z

main is currently red on validate-tests (3): AssertionError: expected 70 to be 69.

Cause

The stdio tool-count invariant is asserted as an absolute count, so two tool-registering PRs that are each correct against the same base race each other:

REST + CLI mirror for loopover_simulate_open_pr_pressure #6751's loopover_simulate_open_pr_pressure mirror (feat(api): add a REST route + CLI mirror for loopover_simulate_open_pr_pressure #6915) bumped 68 → 69
REST + CLI mirror for loopover_intake_idea #6755's loopover_intake_idea mirror (feat(api): REST + CLI mirror for loopover_intake_idea #6916) bumped 68 → 69

Both were correct when written, and both tools registered — leaving 70 live tools against a 69 assertion. Neither diff is individually wrong; the invariant simply can't express two concurrent bumps.

Fix

Pin the count at 70, matching what is actually on main right now:

70 registerStdioTool(...) registrations in packages/loopover-mcp/bin/loopover-mcp.js
70 STDIO_TOOL_DESCRIPTORS entries
the failing CI run itself reports the live server registering 70

Both mirrors are recorded in the header comment so the next bump starts from the real base rather than re-deriving it from a stale line.

Why this matters beyond the invariant

The gate closes contributor PRs on a red required CI, so while main is red unrelated PRs are being auto-closed on inherited failure — the AI review on those correctly notes that nothing in their diffs explains it. This unblocks them.

Test-only change; no source or behaviour touched.

… landed The invariant is asserted as an absolute count, so two tool-registering PRs that are each correct against the same base race each other: JSONbored#6751's loopover_simulate_open_pr_pressure mirror and JSONbored#6755's loopover_intake_idea mirror both bumped 68 -> 69, but both tools registered, leaving 70 live against a 69 assertion. main has been red on validate-tests since, which also closes unrelated contributor PRs on inherited CI failure. Pin the count at 70 -- matching the 70 registerStdioTool registrations and 70 STDIO_TOOL_DESCRIPTORS entries now on main -- and record both mirrors in the header so the next bump starts from the real base.

superagent-security · 2026-07-17T13:46:49Z

Superagent didn't find any vulnerabilities or security issues in this PR.

codecov · 2026-07-17T13:52:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (fd53997) to head (2a9707e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6926      +/-   ##
==========================================
+ Coverage   89.39%   93.71%   +4.31%     
==========================================
  Files         685      685              
  Lines       68357    68357              
  Branches    18726    18726              
==========================================
+ Hits        61108    64058    +2950     
+ Misses       5497     3302    -2195     
+ Partials     1752      997     -755

Flag	Coverage Δ
shard-1	`43.58% <ø> (-0.09%)`	⬇️
shard-2	`36.81% <ø> (-0.02%)`	⬇️
shard-3	`32.68% <ø> (?)`
shard-4	`34.42% <ø> (-0.41%)`	⬇️
shard-5	`31.62% <ø> (+0.43%)`	⬆️
shard-6	`45.85% <ø> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 103 files with indirect coverage changes

loopover-orb · 2026-07-17T13:53:01Z

Caution

🛑 LoopOver review result - reject/close recommended

_{Review updated: 2026-07-17 13:53:17 UTC}

1 file · 1 AI reviewer · 1 blocker · CI green · clean

🛑 Suggested Action - Reject/Close

Review summary
This test-only PR pins the stdio tool-count invariant from 69 to 70 in test/unit/mcp-tool-rename-aliases.test.ts, updating three assertions and the historical header comment to explain that two concurrent PRs (#6751 and #6755) each correctly bumped the count from the same 68-tool base. This is a straightforward, correct fix for a two-way merge race that left main red on validate-tests, and the diff is fully self-consistent with the file's own stated source-of-truth (70 registerStdioTool calls per the PR description). No source or behavior code is touched, only the invariant assertions and their explanatory comment.

Nits — 2 non-blocking

The header comment fix at line 14-15 is a bit dense/garbled given the pre-existing mangled comment above it (line 8 has a stray '#// (feat(mcp): register loopover-mcp maintain queue/approve/reject/pause/resume/set-level/precision as MCP tools (CLI-only today) #6152...' artifact from an earlier bad merge) — consider cleaning that up while touching this block, though it's out of scope for this PR.
Consider adding a lightweight CI check or generator that derives the expected tool count directly from `STDIO_TOOL_DESCRIPTORS.length` instead of hardcoding it in three places, to prevent this exact race from recurring on the next concurrent PR pair.

Why this is blocked

No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

📋 Copy for AI agents — paste into your coding agent

Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

Decision drivers

❌ Code review — 1 blocker (1 reviewer)
❌ Gate result — Blocking (Repo-configured hard blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ No-issue rationale	PR body explains why no issue is linked.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 113 registered-repo PR(s), 55 merged, 5 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	lourincedaging0-commits; Gittensor profile; 113 PR(s), 5 issue(s).
Improvement	ℹ️ Insufficient signal	risk: clean · value: insufficient-signal · LLM: moderate

Review context

Author: lourincedaging0-commits
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: not available
Official Gittensor activity: 113 PR(s), 5 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

loopover-orb · 2026-07-17T13:53:21Z

LoopOver is closing this pull request on the maintainer's behalf (No linked issue detected). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

lourincedaging0-commits requested a review from JSONbored as a code owner July 17, 2026 13:46

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 17, 2026

loopover-orb Bot assigned lourincedaging0-commits Jul 17, 2026

loopover-orb Bot closed this Jul 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(mcp): pin the stdio tool-count invariant at 70 after two mirrors landed#6926

test(mcp): pin the stdio tool-count invariant at 70 after two mirrors landed#6926
lourincedaging0-commits wants to merge 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:fix/tool-count-invariant-70

lourincedaging0-commits commented Jul 17, 2026

Uh oh!

superagent-security Bot commented Jul 17, 2026

Uh oh!

codecov Bot commented Jul 17, 2026

Uh oh!

loopover-orb Bot commented Jul 17, 2026 •

edited

Loading

🛑 LoopOver review result - reject/close recommended

Uh oh!

loopover-orb Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

lourincedaging0-commits commented Jul 17, 2026

Cause

Fix

Why this matters beyond the invariant

Uh oh!

superagent-security Bot commented Jul 17, 2026

Uh oh!

codecov Bot commented Jul 17, 2026

Codecov Report

Uh oh!

loopover-orb Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛑 LoopOver review result - reject/close recommended

Uh oh!

loopover-orb Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

loopover-orb Bot commented Jul 17, 2026 •

edited

Loading